Skip to content

fix(v2): show revoked state on mobile rows - #1712

Merged
lilyshen0722 merged 2 commits into
mainfrom
kai/task031
Sep 16, 2026
Merged

lilyshen0722 merged 2 commits into
mainfrom
kai/task031

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

TASK-032 follow-up for merged #1709.

Dead RoomGrant rows retain the revoked/expired state line at <=760px while live rows keep the phone detail hide. Adds modifier/render/layout coverage and refreshed 390x844 evidence PNG.

Tests: focused V2ConnectorTools + v2-layout-invariants (118), frontend typecheck, focused eslint.

@lilyshen0722
lilyshen0722 merged commit 9e51c7e into main Sep 16, 2026
14 checks passed
samxu01 pushed a commit that referenced this pull request Sep 19, 2026
…side (TASK-050)

The UI hold asks for a before/after pair at 390 and 1200. Wren's read named the one
view that can carry this fix on a phone: the row's `… may use it` line is hidden under
760px by v2.css (#1712), so the audience only paints in the Manage aside.

- before = main dbd5270, after = dbd5270 + this PR's head ede0647
- one backend at main, both frontends pointed at it, same seeded pod and grant
- harness: scripts/ui-evidence-shot.mjs on kai/harness-width-flag @ a730a1e (#1770).
  It now takes --width/--height and --click, refuses a flag it does not implement, and
  prints the viewport it used — so these files are 780x1800 and 2400x1800, not the
  2880x1800 that `--width 390` used to produce under a `-390` name.

Measured: aside @390 `agents allowed` an agent -> localdev; row @1200 same change; row
@390 unchanged, which is what the hide rule requires.
lilyshen0722 added a commit that referenced this pull request Sep 19, 2026
…side (TASK-050)

The UI hold asks for a before/after pair at 390 and 1200. Wren's read named the one
view that can carry this fix on a phone: the row's `… may use it` line is hidden under
760px by v2.css (#1712), so the audience only paints in the Manage aside.

- before = main dbd5270, after = dbd5270 + this PR's head ede0647
- one backend at main, both frontends pointed at it, same seeded pod and grant
- harness: scripts/ui-evidence-shot.mjs on kai/harness-width-flag @ a730a1e (#1770).
  It now takes --width/--height and --click, refuses a flag it does not implement, and
  prints the viewport it used — so these files are 780x1800 and 2400x1800, not the
  2880x1800 that `--width 390` used to produce under a `-390` name.

Measured: aside @390 `agents allowed` an agent -> localdev; row @1200 same change; row
@390 unchanged, which is what the hide rule requires.
lilyshen0722 added a commit that referenced this pull request Sep 19, 2026
… agent" (TASK-050) (#1757)

* fix(v2): name a human in a grant audience instead of calling them "an agent"

A pod grant's audience is a snapshot of the room's members, so it can
name a human; `seats` holds agents only, and every id it could not find
was labelled "an agent". The stranger's Tools row read "an agent, an
agent, C4 smoke may use it" for two people.

Resolve the member's username before falling back to the generic label,
the same helper the grantor line already uses. The row named two options;
this is the first one, and the reason is on the row: enforcement needs an
agent identity, so naming the person is accurate under either reading of
what an audience means, and the audience-model question is left to the
pod rather than settled here.

Mutation-proven: dropping the fallback reds exactly the new case.
Frontend 108 suites / 884 tests, tsc clean. TASK-050.

* docs(evidence): the TASK-050 audience pair at 390 and 1200, row and aside (TASK-050)

The UI hold asks for a before/after pair at 390 and 1200. Wren's read named the one
view that can carry this fix on a phone: the row's `… may use it` line is hidden under
760px by v2.css (#1712), so the audience only paints in the Manage aside.

- before = main dbd5270, after = dbd5270 + this PR's head ede0647
- one backend at main, both frontends pointed at it, same seeded pod and grant
- harness: scripts/ui-evidence-shot.mjs on kai/harness-width-flag @ a730a1e (#1770).
  It now takes --width/--height and --click, refuses a flag it does not implement, and
  prints the viewport it used — so these files are 780x1800 and 2400x1800, not the
  2880x1800 that `--width 390` used to produce under a `-390` name.

Measured: aside @390 `agents allowed` an agent -> localdev; row @1200 same change; row
@390 unchanged, which is what the hide rule requires.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant