fix(v2): show revoked state on mobile rows - #1712
Merged
Merged
Conversation
samxu01
force-pushed
the
kai/task031
branch
from
September 16, 2026 04:36
a4f7334 to
ca30fb1
Compare
samxu01
pushed a commit
that referenced
this pull request
Sep 19, 2026
…side (TASK-050) The UI hold asks for a before/after pair at 390 and 1200. Wren's read named the one view that can carry this fix on a phone: the row's `… may use it` line is hidden under 760px by v2.css (#1712), so the audience only paints in the Manage aside. - before = main dbd5270, after = dbd5270 + this PR's head ede0647 - one backend at main, both frontends pointed at it, same seeded pod and grant - harness: scripts/ui-evidence-shot.mjs on kai/harness-width-flag @ a730a1e (#1770). It now takes --width/--height and --click, refuses a flag it does not implement, and prints the viewport it used — so these files are 780x1800 and 2400x1800, not the 2880x1800 that `--width 390` used to produce under a `-390` name. Measured: aside @390 `agents allowed` an agent -> localdev; row @1200 same change; row @390 unchanged, which is what the hide rule requires.
lilyshen0722
added a commit
that referenced
this pull request
Sep 19, 2026
…side (TASK-050) The UI hold asks for a before/after pair at 390 and 1200. Wren's read named the one view that can carry this fix on a phone: the row's `… may use it` line is hidden under 760px by v2.css (#1712), so the audience only paints in the Manage aside. - before = main dbd5270, after = dbd5270 + this PR's head ede0647 - one backend at main, both frontends pointed at it, same seeded pod and grant - harness: scripts/ui-evidence-shot.mjs on kai/harness-width-flag @ a730a1e (#1770). It now takes --width/--height and --click, refuses a flag it does not implement, and prints the viewport it used — so these files are 780x1800 and 2400x1800, not the 2880x1800 that `--width 390` used to produce under a `-390` name. Measured: aside @390 `agents allowed` an agent -> localdev; row @1200 same change; row @390 unchanged, which is what the hide rule requires.
lilyshen0722
added a commit
that referenced
this pull request
Sep 19, 2026
… agent" (TASK-050) (#1757) * fix(v2): name a human in a grant audience instead of calling them "an agent" A pod grant's audience is a snapshot of the room's members, so it can name a human; `seats` holds agents only, and every id it could not find was labelled "an agent". The stranger's Tools row read "an agent, an agent, C4 smoke may use it" for two people. Resolve the member's username before falling back to the generic label, the same helper the grantor line already uses. The row named two options; this is the first one, and the reason is on the row: enforcement needs an agent identity, so naming the person is accurate under either reading of what an audience means, and the audience-model question is left to the pod rather than settled here. Mutation-proven: dropping the fallback reds exactly the new case. Frontend 108 suites / 884 tests, tsc clean. TASK-050. * docs(evidence): the TASK-050 audience pair at 390 and 1200, row and aside (TASK-050) The UI hold asks for a before/after pair at 390 and 1200. Wren's read named the one view that can carry this fix on a phone: the row's `… may use it` line is hidden under 760px by v2.css (#1712), so the audience only paints in the Manage aside. - before = main dbd5270, after = dbd5270 + this PR's head ede0647 - one backend at main, both frontends pointed at it, same seeded pod and grant - harness: scripts/ui-evidence-shot.mjs on kai/harness-width-flag @ a730a1e (#1770). It now takes --width/--height and --click, refuses a flag it does not implement, and prints the viewport it used — so these files are 780x1800 and 2400x1800, not the 2880x1800 that `--width 390` used to produce under a `-390` name. Measured: aside @390 `agents allowed` an agent -> localdev; row @1200 same change; row @390 unchanged, which is what the hide rule requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK-032 follow-up for merged #1709.
Dead RoomGrant rows retain the revoked/expired state line at <=760px while live rows keep the phone detail hide. Adds modifier/render/layout coverage and refreshed 390x844 evidence PNG.
Tests: focused V2ConnectorTools + v2-layout-invariants (118), frontend typecheck, focused eslint.